Lock continuation to avoid handleEvent assert.#4082
Merged
shinrich merged 1 commit intoapache:masterfrom Aug 9, 2018
Merged
Conversation
SolidWallOfCode
approved these changes
Aug 9, 2018
Contributor
|
do we know the when they both are different? |
Contributor
|
And what happens when they are the same? Do you not now try to lock the same mutex twice ? |
Contributor
|
I'm going to remove the 7.1.5 Project on this, since going forward, we will need to make a second PR against the 7.1.x for proposed back ports. |
Contributor
|
Cherry picked to 8.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw an assert after pulling in the the handleEvent lock/assert fix.
Since I was unclear on the return value expectations, I just added code to grab the action.continuation->mutex lock.
Digging into our core here, the action.mutex and the action.continuation->mutex were different. The action.mutex corresponded to the HostDBContinuation mutex and the action.continuation->mutex corresponded to the HttpSM->mutex.